Implement Iterator protocol and resource management for CSV readers#642
Merged
laughingman7743 merged 2 commits intomasterfrom Jan 4, 2026
Merged
Implement Iterator protocol and resource management for CSV readers#642laughingman7743 merged 2 commits intomasterfrom
laughingman7743 merged 2 commits intomasterfrom
Conversation
- DefaultCSVReader and AthenaCSVReader now inherit from collections.abc.Iterator - Added close() method to properly release file resources - Added context manager support (__enter__/__exit__) - Updated ResultSet to use reader's close() method (no exception suppression) - Removed _csv_file instance variable from ResultSet (reader manages file lifecycle) - Removed unnecessary contextlib.suppress (length check already handles empty files) - Added unit tests for Iterator protocol, close(), and context manager - No _closed flag needed - use _file is None check instead 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
laughingman7743
force-pushed
the
feature/reader-iterator-protocol
branch
from
4868480 to
a2c3c73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collections.abc.Iteratorprotocolclose()method and context manager support for proper resource managementChanges
pyathena/s3fs/reader.pyDefaultCSVReaderandAthenaCSVReadernow inherit fromIteratorclose()method to release file resources (uses_file = Nonepattern, no flag needed)__enter__/__exit__for context manager support__next__checks if closed before readingpyathena/s3fs/result_set.py_csv_fileinstance variable (reader now manages file lifecycle)close()now callsreader.close()instead of direct file closeTest plan
make chkpasses (lint, format, type check)🤖 Generated with Claude Code